Added comment_clause adapter to support persist_docs
#353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit added feature to support views documentation in Unity Catalog using dbt documentation.
CezaryPukownik
requested review from
andrefurlan-db,
susodapop and
ueshin
as code owners
|
@CezaryPukownik can you either describe the issue you are trying to solve in the PR or link to an issue that this solves? Also for us to consider a behavioral change like this, unit tests evaluating that the macro performs the expected behavior go a long way towards giving us confidence to merge. Apologies for the delay in response. |
|
I checked this out and unfortunately it breaks our existing persist_docs tests. |
|
There is a PR out in dbt-spark that I am working with dbt-labs to get merged that will accomplish this without breaking the existing table comment support: dbt-labs/dbt-spark#866 Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit added feature to support views documentation in Unity Catalog using dbt documentation.